Skip to content

feat(meta-service): add metrics for watch stream#18209

Merged
drmingdrmer merged 1 commit intodatabendlabs:mainfrom
drmingdrmer:317-metrics-watch
Jun 21, 2025
Merged

feat(meta-service): add metrics for watch stream#18209
drmingdrmer merged 1 commit intodatabendlabs:mainfrom
drmingdrmer:317-metrics-watch

Conversation

@drmingdrmer
Copy link
Copy Markdown
Member

@drmingdrmer drmingdrmer commented Jun 21, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(meta-service): add metrics for watch stream

Add two metrics:

  • the number of items sent when sending watch stream initialization
    data(all existent key-values),
  • and the number of items sent when a key-value changed
metasrv_meta_network_watch_initialization_total 2753400
metasrv_meta_network_watch_change_total         2753394

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Other

Related Issues


This change is Reviewable

@github-actions github-actions Bot added the pr-feature this PR introduces a new feature to the codebase label Jun 21, 2025
@drmingdrmer drmingdrmer requested a review from everpcpc June 21, 2025 04:16
Add two metrics:
- the number of items sent when sending watch stream initialization
  data(all existent key-values),
- and the number of items sent when a key-value changed

```
metasrv_meta_network_watch_initialization_total 2753400
metasrv_meta_network_watch_change_total         2753394
```
@drmingdrmer drmingdrmer marked this pull request as ready for review June 21, 2025 04:16
@drmingdrmer drmingdrmer merged commit 89cb39a into databendlabs:main Jun 21, 2025
79 of 82 checks passed
@drmingdrmer drmingdrmer deleted the 317-metrics-watch branch June 21, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants